feat: add support for DROP IF EXISTS clause #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyabu12
suggested changes
Jun 20, 2023
|
There was 1 error:
1) Colopl\Spanner\Tests\Schema\BlueprintTest::test_dropIfExists
Google\Cloud\Core\Exception\BadRequestException: {
"message": "Error parsing Spanner DDL statement: drop table if exists `Test3` : Syntax error on line 1, column 12: Encountered 'if' while parsing: identifier",
"code": 3,
"status": "INVALID_ARGUMENT",
"details": [
{
"@type": "grpc-status-details-bin",
"data": "<Unknown Binary Data>"
}
]
}
/project/vendor/google/cloud-core/src/GrpcRequestWrapper.php:263
/project/vendor/google/cloud-core/src/GrpcRequestWrapper.php:151
/project/vendor/google/cloud-core/src/GrpcTrait.php:82
/project/vendor/google/cloud-spanner/src/Connection/Grpc.php:691
/project/vendor/google/cloud-spanner/src/Database.php:517
/project/src/Concerns/ManagesDataDefinitions.php:62
/project/src/Connection.php:306
/project/tests/Schema/BlueprintTest.php:94
ERRORS!
Tests: 108, Assertions: 374, Errors: 1, Skipped: 2.According to the documentation, the https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#drop_table |
|
Waiting for emulator to add support. |
taka-oyama
changed the title
|
I've changed the title to DRAFT |
taka-oyama
force-pushed
the
feature/drop-if-exists
branch
from
e48ad4b
to
532c1db
Compare
taka-oyama
changed the title
Co-authored-by: Tomohito YABU <tyabu1212@gmail.com>
taka-oyama
force-pushed
the
feature/drop-if-exists
branch
from
e372e65
to
fa39860
Compare
taka-oyama
force-pushed
the
feature/drop-if-exists
branch
from
fa39860
to
c1fec4f
Compare
zeriyoshi
approved these changes
Jul 7, 2023
|
Emulator added support and tests are now passing. https://github.com/GoogleCloudPlatform/cloud-spanner-emulator/releases/tag/v1.5.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #111
Checklist